Add operation hook #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taoeffect
reviewed
Jan 5, 2026
taoeffect
reviewed
Jan 5, 2026
Comment on lines
+950
to
+951
| const manifestHash = this.config.contracts.manifests[contractName] | ||
| if (manifestHash) { |
Member
There was a problem hiding this comment.
This hook will only run on the latest version of the contract, is that intentional?
corrideat
commented
Jan 5, 2026
| throw new Error('Inside OP_ATOMIC: no matching signing key was defined') | ||
| } | ||
| await (opFns[u[0]] as (x: unknown) => Promise<void>)(u[1]) | ||
| sbp('chelonia/private/operationHook', contractID, contractName, message, state, i) |
Member
Author
There was a problem hiding this comment.
Is this something that should also be done for config.preOp and config.postOp? I mean, should this be something like this? (ignore the broken processOp part, which would need to be adjusted)
if (config[`preOp_${opT}`]) {
processOp = config[`preOp_${opT}`]!(message, state, i) !== false && processOp
}
if (processOp) {
await (opFns[u[0]] as (x: unknown) => Promise<void>)(u[1])
sbp('chelonia/private/operationHook', contractID, contractName, message, state, i)
config.postOp?.(message, state, i)
config[`postOp_${opT}`]?.(message, state, i) // hack to fix syntax highlighting `
}
Member
There was a problem hiding this comment.
If you mean to ask whether we should also call postOp/preOp here inside of the OP_ATOMIC, no, I think that's excessive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to okTurtles/group-income#2988