Cleanup include usage #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuAlphaOmegaEpsilon
force-pushed
the
include-cleanup
branch
from
dda4354 to
9b4852e
Compare
Contributor
Author
|
Rebased and adjusted after #162 was merged into master |
MuAlphaOmegaEpsilon
force-pushed
the
include-cleanup
branch
2 times, most recently
from
a403cc3 to
99ae065
Compare
MuAlphaOmegaEpsilon
force-pushed
the
include-cleanup
branch
from
99ae065 to
6ad2965
Compare
Contributor
Author
|
Fixed the CI build for Windows, fixedup the change into the same commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a cleanup of include statements.
Previously there were some includes that weren't used at all and others that were used only because they transitively included other files.
By removing unnecessary includes and by moving useful ones from header files into cpp files, this change dimishes the amount of preprocessed code that is fed to the compiler, perhaps improving the parsing (useful for IDEs as well) and compilation time.
These changes are meant not to have any functional impact on the code itself.