Skip to content

Conversation

@raphael-goetz
Copy link
Contributor

Resolves: #56

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes HTTP v1.1 REST routes from the Octopus gRPC service, converting it to a pure gRPC-only API by removing all HTTP/REST gateway annotations.

Key Changes:

  • Removed HTTP annotations from three RPC methods (Get, Write, Call) in the proto definition
  • Removed the google.api.annotations import dependency from proto and generated Go code
  • Cleared all HTTP REST endpoints from the OpenAPI specification

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
proto/v1/api.proto Removed google.api.annotations import and HTTP options from Get, Write, and Call RPC methods
sdk/go/v1/api.pb.go Removed googleapis annotations import and regenerated protobuf descriptor without HTTP options
sdk/openapi/octopus.swagger.json Removed all v1 REST paths (/v1/entries and /v1/objects), leaving an empty paths object

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@raphael-goetz raphael-goetz merged commit 52eb2cf into main Dec 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

drop: remove rest routes

3 participants