Skip to content

Fix infinite recursion when you link gearboxes in a loop #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
norrbotten wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix infinite recursion when you link gearboxes in a loop #330

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93be162
fix infinite recursion when you link gearboxes in a loop
Aug 19, 2019
3c77dc4
source/target print was kinda unnecessary
Aug 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion lua/entities/acf_gearbox.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,6 +937,30 @@ function ENT:ChangeDrive(value)

end

-- Searches the "tree" which gearbox-gearbox connections forms, if the source is found
-- anywhere in the targets link tree, this function will return true
function ACF_SearchGearboxLinkTree(source, target)
local queue = { target }

-- search the link tree
while #queue > 0 do
local ent = table.remove(queue)

if ent == source then
return true
end

if not ent.WheelLink then continue end

-- add each link to the queue
for k, v in ipairs(ent.WheelLink) do
table.insert(queue, v.Ent)
end
end

return false
end

function ENT:Link( Target )

if not IsValid( Target ) or not table.HasValue( { "prop_physics", "acf_gearbox", "tire" }, Target:GetClass() ) then
Expand All @@ -949,7 +973,11 @@ function ENT:Link( Target )
return false, "That is already linked to this gearbox!"
end
end


if ACF_SearchGearboxLinkTree(self, Target) then
return false, "You cannot link gearboxes in a loop!"
end

-- make sure the angle is not excessive
local InPos = Vector( 0, 0, 0 )
if Target.IsGeartrain then
Expand Down