Skip to content

Conversation

@canerakdas
Copy link
Member

@canerakdas canerakdas commented Jan 7, 2026

Description

With this PR, we aim to move the customized search box styles currently used in doc-kit into the shared ui-components package that we also use on the website, and to fix the overflow issue in doc-kit

ref: https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1767753183463229

Validation

The search box should be visible and fully usable in the preview without any issues.

Example expanded content;
image

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@canerakdas canerakdas requested a review from a team as a code owner January 7, 2026 17:22
Copilot AI review requested due to automatic review settings January 7, 2026 17:22
@vercel
Copy link

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nodejs-org Ready Ready Preview Jan 7, 2026 6:45pm

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes overflow issues in the search modal by adding responsive width constraints and text truncation styles to the ui-components package. The changes ensure the search modal and its components render properly without overflow on various screen sizes.

  • Added responsive max-width constraint to the search modal at medium breakpoint
  • Implemented proper text truncation for search result descriptions
  • Ensured tab list maintains proper width to prevent shrinking

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/ui-components/src/Common/Search/Modal/index.module.css Added md:max-w-[42rem] to constrain modal width on medium screens
packages/ui-components/src/Common/Search/Results/Hit/index.module.css Added text truncation styles to hit descriptions and flex controls to prevent icon shrinking
packages/ui-components/src/Common/Search/Results/Tabs/index.module.css Added w-max to prevent tabs from shrinking below content width
packages/ui-components/package.json Bumped package version from 1.4.1 to 1.4.2 for the bug fix release

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Make sure to resolve conflicts)

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.66%. Comparing base (914daa3) to head (fcab3a1).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8523      +/-   ##
==========================================
+ Coverage   74.65%   74.66%   +0.01%     
==========================================
  Files         102      102              
  Lines        8956     8956              
  Branches      306      306              
==========================================
+ Hits         6686     6687       +1     
+ Misses       2268     2267       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovflowd ovflowd added this pull request to the merge queue Jan 8, 2026
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Jan 8, 2026
Merged via the queue into nodejs:main with commit 40f4182 Jan 8, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants