-
-
Notifications
You must be signed in to change notification settings - Fork 34.3k
sqlite: enable defensive mode by default #61266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61266 +/- ##
==========================================
- Coverage 88.53% 88.53% -0.01%
==========================================
Files 703 704 +1
Lines 208599 208753 +154
Branches 40229 40274 +45
==========================================
+ Hits 184685 184820 +135
- Misses 15939 15945 +6
- Partials 7975 7988 +13
🚀 New features to boost your workflow:
|
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Renegade334
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the correct approach. I don't see any barriers to this being semver-minor, with the API being experimental and with such a small minority of users likely to be impacted.
cjihrig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that this doesn't have to be semver minor. It's not adding a new feature and there is no semver contract for experimental features.
This PR enables SQLite defensive mode by default.
More information in the SQLite documentation and the discussion in the PR that introduced this flag.