build: fix inconsistent quoting in Makefile
#60511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
avivkeller
approved these changes
Jan 3, 2026
aduh95
force-pushed
the
make-quoting-consistent-again
branch
from
9408ced to
fff752f
Compare
aduh95
added
the
author ready
Collaborator
avivkeller
added
the
commit-queue
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60511 +/- ##
==========================================
- Coverage 88.53% 88.01% -0.53%
==========================================
Files 704 704
Lines 208759 208759
Branches 40277 40198 -79
==========================================
- Hits 184825 183731 -1094
- Misses 15934 16992 +1058
- Partials 8000 8036 +36 🚀 New features to boost your workflow:
|
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/60511 ✔ Done loading data for nodejs/node/pull/60511 ----------------------------------- PR info ------------------------------------ Title build: fix inconsistent quoting in `Makefile` (#60511) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:make-quoting-consistent-again -> nodejs:main Labels build, author ready, needs-ci Commits 1 - build: fix inconsistent quoting in `Makefile` Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/60511 Reviewed-By: Aviv Keller <me@aviv.sh> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60511 Reviewed-By: Aviv Keller <me@aviv.sh> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - build: fix inconsistent quoting in `Makefile` ℹ This PR was created on Fri, 31 Oct 2025 12:55:26 GMT ✔ Approvals: 1 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/60511#pullrequestreview-3624552602 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-01-04T16:17:13Z: https://ci.nodejs.org/job/node-test-pull-request/70667/ - Querying data for job/node-test-pull-request/70667/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/20697827382 |
avivkeller
approved these changes
Jan 4, 2026
avivkeller
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 6218d14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
available-noderesults in something that looks likeif [ -x ""…/node"" ] && [ -e ""…/node"" ]; then…, the double quoting is clearly not helpful.I went with using single quotes in case the path contains weird chars (although it wouldn't help if PWD itself contains a single quote, but oh well), I left out the
$(PYTHON)calls in case someone is passing flags to Python that way.