Skip to content

Conversation

@dkleinF5
Copy link

@dkleinF5 dkleinF5 commented Nov 25, 2025

Proposed changes

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@dkleinF5 dkleinF5 requested a review from a team as a code owner November 25, 2025 14:32
@github-actions github-actions bot added documentation Improvements or additions to documentation product/waf Issues related to F5 WAF for NGINX labels Nov 25, 2025
@github-actions
Copy link

github-actions bot commented Nov 25, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/1485/

@dkleinF5 dkleinF5 changed the title docs: add missing prerequisite for installation [Draft] docs: add missing prerequisite for installation Nov 25, 2025
@dkleinF5 dkleinF5 requested a review from a team as a code owner November 26, 2025 08:08
@dkleinF5
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

@dkleinF5 dkleinF5 force-pushed the waf/missing-prerequisite branch from d366350 to dc87dc4 Compare November 27, 2025 07:11
@ADubhlaoich ADubhlaoich self-requested a review November 27, 2025 11:11
@ADubhlaoich ADubhlaoich changed the base branch from main to waf-release-5.10 November 28, 2025 16:57
@ADubhlaoich ADubhlaoich changed the base branch from waf-release-5.10 to main December 1, 2025 10:09
@dkleinF5 dkleinF5 force-pushed the waf/missing-prerequisite branch from c0adb94 to d54baa0 Compare December 1, 2025 12:34
@dkleinF5 dkleinF5 changed the title [Draft] docs: add missing prerequisite for installation Docs: add missing prerequisite for installation Dec 1, 2025
@dkleinF5 dkleinF5 force-pushed the waf/missing-prerequisite branch from d54baa0 to 9f5a581 Compare December 1, 2025 17:13
Copy link
Contributor

@JTorreG JTorreG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a TODO label

@dkleinF5 dkleinF5 force-pushed the waf/missing-prerequisite branch from dfc4c24 to 04698aa Compare December 2, 2025 07:57
Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM: approval pending feedback.

Please run the linting tools on this branch, which can be executed automatically with pre-commit.

Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor changes for content flow and formatting.

@dkleinF5 dkleinF5 force-pushed the waf/missing-prerequisite branch 2 times, most recently from 5645ca7 to 23eddc1 Compare December 3, 2025 15:34
@dkleinF5 dkleinF5 requested a review from ADubhlaoich December 3, 2025 15:34
@dkleinF5 dkleinF5 force-pushed the waf/missing-prerequisite branch from cb32368 to 1d6dc86 Compare December 7, 2025 07:58
dkleinF5 and others added 12 commits December 7, 2025 10:24
Co-authored-by: yar <y82@users.noreply.github.com>
Co-authored-by: yar <y82@users.noreply.github.com>
Co-authored-by: yar <y82@users.noreply.github.com>
Co-authored-by: yar <y82@users.noreply.github.com>
Co-authored-by: yar <y82@users.noreply.github.com>
Co-authored-by: yar <y82@users.noreply.github.com>
Co-authored-by: yar <y82@users.noreply.github.com>
Co-authored-by: yar <y82@users.noreply.github.com>
Co-authored-by: yar <y82@users.noreply.github.com>
@dkleinF5 dkleinF5 marked this pull request as ready for review December 8, 2025 09:50
@dkleinF5 dkleinF5 requested a review from y82 December 8, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/waf Issues related to F5 WAF for NGINX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants