fix: DavPluging arguments #1028
Merged
+2
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
approved these changes
Jan 7, 2026
Member
|
already ready to review in #1027 |
Member
Author
Done
This is to make psalm happy, with the latest change in master. |
Entity $id is now string|int|null in master so this is not needed and
even before this was not needed as typing on $id wasn't enforced.
The only important part are:
- `addType('id', STRING)` for the DB type to be correct
- `@method` tag in the api doc for psalm
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/fix-saml
branch
from
683f972 to
acb4171
Compare
come-nc
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entity $id is now string|int|null in master so this is not needed and
even before this was not needed as typing on $id wasn't enforced.
The only important part are:
addType('id', STRING)for the DB type to be correct@methodtag in the api doc for psalm