chore: use matrix for psalm php version #5258
Draft
+38
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
elzody
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 📝 Office team
elzody
force-pushed
the
fix/psalm-php-version
branch
2 times, most recently
from
b655a23 to
3c7d14b
Compare
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
elzody
force-pushed
the
fix/psalm-php-version
branch
from
3c7d14b to
f2a1859
Compare
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
elzody
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were some issues running psalm on CI due to something related to the new maximum PHP version of 8.5. It seems like it was still caching or something, and was complaining that only 8.1-8.4 were supported.
There is probably another or better way to resolve it, but I think we can run the static analysis on all supported versions of PHP so that we can ensure support.
Checklist