Skip to content

feat(node): allow to cast as JSON #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 7 commits into from
Nov 18, 2025
Merged

feat(node): allow to cast as JSON #1349

skjnldsv merged 7 commits into from
Nov 18, 2025

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Oct 30, 2025

This allow us to do the following:

new File(...JSON.parse(file.toString()))

This should allow us to drop any inter-dependencies and thus storing them in localstorage or forwarding them as events between tabs

@skjnldsv
fix(node): cloning
4bf0659 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv self-assigned this Oct 30, 2025
@skjnldsv skjnldsv requested review from ShGKme and susnux October 30, 2025 11:06
@skjnldsv skjnldsv added type: enhancement 🚀 New feature or request 3. to review 3️⃣ Waiting for reviews labels Oct 30, 2025
@skjnldsv
Copy link
Contributor Author

skjnldsv commented Oct 30, 2025

Shall we add some preventiuve measures to avoid devs using complex data in attributes?
Like only allowing basic JSON-compatible types ? (plain objects, arrays, strings, numbers, booleans and null) .

@skjnldsv skjnldsv changed the title fix(node): cloning feat(node): allow to cast as String Oct 30, 2025
susnux
susnux reviewed Nov 1, 2025
View reviewed changes
skjnldsv and others added 3 commits November 4, 2025 09:57
@skjnldsv
fix(node): use structuredClone to clone data
b7ce2fe 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv
feat(node): allow to cast as String
a9f461e 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
chore: add cloning tests
563fcf2 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
fix(node): use toJSON
78e979d 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv requested a review from susnux November 4, 2025 09:05
@skjnldsv skjnldsv mentioned this pull request Nov 4, 2025
Merged
@skjnldsv
chore: allow npm 11
3d61d88 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/clone branch 2 times, most recently from 44b01e3 to 9d40402 Compare November 18, 2025 09:51
@skjnldsv
Merge branch 'fix/clone' into feat/to-string
1bcc516 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv merged commit a41e0ac into fix/clone Nov 18, 2025
7 of 8 checks passed
@skjnldsv skjnldsv deleted the feat/to-string branch November 18, 2025 09:59
@skjnldsv
Copy link
Contributor Author

skjnldsv commented Nov 18, 2025

Let's merge into the other branch

@skjnldsv skjnldsv changed the title feat(node): allow to cast as String feat(node): allow to cast as JSON Nov 27, 2025
@skjnldsv skjnldsv mentioned this pull request Nov 27, 2025
Merged
@skjnldsv skjnldsv mentioned this pull request Dec 11, 2025
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme Awaiting requested review from ShGKme

@susnux susnux Awaiting requested review from susnux

Assignees

@skjnldsv skjnldsv

Labels

3. to review 3️⃣ Waiting for reviews type: enhancement 🚀 New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv @susnux