ENH speed up oblique splitting & MAINT specify sklearn version #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A list of command code to reset
Co-authored-by: Adam Li <adam2392@gmail.com>
Co-authored-by: Adam Li <adam2392@gmail.com>
make floyd_sample_indices() inlined
Fast oblique
PSSF23
reviewed
Jun 19, 2025
Member
PSSF23
left a comment
PSSF23
left a comment
There was a problem hiding this comment.
Remember to squash merge when merging a PR.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
PSSF23
changed the title
This reverts commit 18ee025.
PSSF23
reviewed
Jul 10, 2025
Member
PSSF23
left a comment
PSSF23
left a comment
There was a problem hiding this comment.
I updated the fork version which should resolve some errors, ideally.
PSSF23
added a commit
to neurodata/scikit-learn
that referenced
this pull request
Jul 10, 2025
According to errors in neurodata/treeple#361, `xfail_checks` is not available in the tags.
PSSF23
requested changes
Jul 10, 2025
Member
PSSF23
left a comment
PSSF23
left a comment
There was a problem hiding this comment.
Alright! Now we are onto some real performance bugs. See the error logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Adam and Hao,
Can we merge fast oblique to main branch! Happy to discuss and test more if needed!