Skip to content

Conversation

@ncode
Copy link
Owner

@ncode ncode commented Sep 12, 2025

This pull request updates the tag comparison logic in the TagIt service to ensure only prefixed tags are considered for updates, while preserving non-prefixed tags. It also adds a new test case to verify that no update occurs when prefixed tags remain unchanged.

Tag comparison logic improvements:

  • Modified needsTag in pkg/tagit/tagit.go to extract prefixed and non-prefixed tags, compare only prefixed tags with the update, and combine non-prefixed tags with the updated tags for the result. This prevents unnecessary updates and ensures original non-prefixed tags are retained.

Test coverage enhancements:

  • Added a test case to TestNeedsTag in pkg/tagit/tagit_test.go to verify that no update occurs when prefixed tags are unchanged, improving reliability of the tag update logic.

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.18%. Comparing base (09d3fe8) to head (488c3f7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   88.99%   89.18%   +0.19%     
==========================================
  Files           8        8              
  Lines         436      444       +8     
==========================================
+ Hits          388      396       +8     
  Misses         36       36              
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ncode ncode merged commit eae6409 into main Sep 12, 2025
5 checks passed
@ncode ncode deleted the juliano/re-tag-bug branch September 12, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant