Skip to content

Conversation

@natuan9
Copy link
Owner

@natuan9 natuan9 commented Mar 25, 2025

Change:

  • This commit makes the Service field required, so the Service should be set when the Provider is changed rather than when creating the IAP Account

sebastienbeau and others added 21 commits March 25, 2025 16:23
Moving this behaviour in a new module in server-env repo
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-15.0/server-tools-15.0-iap_alternative_provider
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-iap_alternative_provider/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-iap_alternative_provider
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-iap_alternative_provider/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-iap_alternative_provider
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-iap_alternative_provider/
Currently translated at 100.0% (7 of 7 strings)

Translation: server-tools-16.0/server-tools-16.0-iap_alternative_provider
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-iap_alternative_provider/it/
Currently translated at 100.0% (7 of 7 strings)

Translation: server-tools-16.0/server-tools-16.0-iap_alternative_provider
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-iap_alternative_provider/es/
Copy link

@nguyenminhchien nguyenminhchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test was failed
image


def _get_service_from_provider(self):
"""In case that the provider only propose one service you can
return the service_id in your module to simplify the user interface"""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return the service_id in your module to simplify the user interface"""
return the service in your module to simplify the user interface"""

record.service_name = service

@api.model_create_multi
def create(self, vals_list):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should keep this method in the case a record of iap.account created from csv or xml file

@natuan9 natuan9 force-pushed the 18.0-mig-iap_alternative_provider branch from ac3af18 to 340257c Compare March 28, 2025 02:59
@natuan9 natuan9 requested a review from nguyenminhchien March 28, 2025 03:03
@natuan9 natuan9 force-pushed the 18.0-mig-iap_alternative_provider branch from 340257c to 417ea68 Compare April 2, 2025 03:03
@natuan9 natuan9 force-pushed the 18.0-mig-iap_alternative_provider branch from 417ea68 to c182d83 Compare April 3, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.