Fix #1516, Patch virtual mount point checking #1517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sponsored by 21Software
Checklist (Please check before submitting)
Describe the contribution
Reject any paths which might be part of a path traversal attack by matching directory entries such as
.and..at the end of the given path. This hardens a vulnerability where an attacker might be able to write files in unauthorized locations outside of a virtual mount point directory. Fixes #1516.Testing performed
Steps taken to test the contribution:
*Please note that I am new to cFS, and would welcome advice on how to properly test virtual mount point functionality. I'm unsure if I'll be able to contribute unit tests due to lack of time.
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
System(s) tested on
Additional context
CVE-2025-25371
NASA cFS version Aquila Software Vulnerability Assessment
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Levi Shafter - 21Software