Skip to content

Conversation

@thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

Expected behavior changes
No change to behavior.

Contributor Info
Avi Weiss @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-1397-rename-overloaded-CFE-EVS-PacketID-t branch 2 times, most recently from 658c84e to 4cc2a65 Compare December 3, 2023 00:59
@thnkslprpt thnkslprpt force-pushed the fix-1397-rename-overloaded-CFE-EVS-PacketID-t branch from 4cc2a65 to c6553fc Compare December 14, 2023 03:57
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I prefer the name "context" but this changes a public API. Some existing apps are referring to the PacketID name so it requires more discussion as to whether we really want to change it. For example the "HS" app is using PacketID, so this breaks HS. At a minimum this would need to go through the deprecation process (but I'm not sure if a simple name change warrants that, if nothing was actually broken)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overloaded "PacketID" use in CFE_EVS_PacketID

2 participants