Fix #2341, Rename TimeA/TimeB parameter to improve consistency #2342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| UT_GenStub_AddParam(CFE_TIME_Compare, CFE_TIME_SysTime_t, TimeA); | ||
| UT_GenStub_AddParam(CFE_TIME_Compare, CFE_TIME_SysTime_t, TimeB); | ||
| UT_GenStub_AddParam(CFE_TIME_Compare, CFE_TIME_SysTime_t, Time1); |
Check warning
Code scanning / CodeQL
Uses of recursion
| UT_GenStub_AddParam(CFE_TIME_Compare, CFE_TIME_SysTime_t, TimeA); | ||
| UT_GenStub_AddParam(CFE_TIME_Compare, CFE_TIME_SysTime_t, TimeB); | ||
| UT_GenStub_AddParam(CFE_TIME_Compare, CFE_TIME_SysTime_t, Time1); | ||
| UT_GenStub_AddParam(CFE_TIME_Compare, CFE_TIME_SysTime_t, Time2); |
Check warning
Code scanning / CodeQL
Uses of recursion
| ** Compute the amount of time "since" the tone... | ||
| */ | ||
| if (CFE_TIME_Compare(Reference->CurrentLatch, Reference->AtToneLatch) == CFE_TIME_A_LT_B) | ||
| if (CFE_TIME_Compare(Reference->CurrentLatch, Reference->AtToneLatch) == CFE_TIME_1_LT_2) |
Check warning
Code scanning / CodeQL
Uses of recursion
| ** Compute the amount of time "since" the tone... | ||
| */ | ||
| if (CFE_TIME_Compare(Reference->CurrentLatch, Reference->AtToneLatch) == CFE_TIME_A_LT_B) | ||
| if (CFE_TIME_Compare(Reference->CurrentLatch, Reference->AtToneLatch) == CFE_TIME_1_LT_2) |
Check warning
Code scanning / CodeQL
Side effect in a Boolean expression
| * ---------------------------------------------------- | ||
| */ | ||
| CFE_TIME_Compare_t CFE_TIME_Compare(CFE_TIME_SysTime_t TimeA, CFE_TIME_SysTime_t TimeB) | ||
| CFE_TIME_Compare_t CFE_TIME_Compare(CFE_TIME_SysTime_t Time1, CFE_TIME_SysTime_t Time2) |
Check notice
Code scanning / CodeQL
Long function without assertion
| * | ||
| *-----------------------------------------------------------------*/ | ||
| CFE_TIME_Compare_t CFE_TIME_Compare(CFE_TIME_SysTime_t TimeA, CFE_TIME_SysTime_t TimeB) | ||
| CFE_TIME_Compare_t CFE_TIME_Compare(CFE_TIME_SysTime_t Time1, CFE_TIME_SysTime_t Time2) |
Check notice
Code scanning / CodeQL
Long function without assertion
thnkslprpt
force-pushed
the
fix-2341-make-time1-time2-consistent
branch
from
e7e04bf to
232e463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
TimeA/TimeBparameter names toTime1/Time2- making all consistent across cFE (the other option is to reverse this and convert the others to TimeA/TimeB)CFE_TIME_A_GT_BandCFE_TIME_A_LT_BtoCFE_TIME_1_GT_2andCFE_TIME_1_LT_2to remain consistentNote: If this PR is merged it will require a minor update to SC which utilises the
CFE_TIME_A_GT_Benumerated type here and in a couple of tests.Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Coverage/Functional Tests etc.).
Expected behavior changes
Contributor Info
Avi Weiss @thnkslprpt