Fix #2339, Refactor common logic out of CFE_TIME_SetTime/MET/STCFCmd()
#2340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| NewTime.Subseconds = CFE_TIME_Micro2SubSecs(CommandPtr->MicroSeconds); | ||
|
|
||
| CFE_TIME_SetTime(NewTime); | ||
| SetTimeFunc(NewTime); |
Check notice
Code scanning / CodeQL
Use of non-constant function pointer
| * | ||
| *-----------------------------------------------------------------*/ | ||
| int32 CFE_TIME_SetTimeCmd(const CFE_TIME_SetTimeCmd_t *data) | ||
| static void CFE_TIME_SetCommand(const CFE_TIME_TimeCmd_Payload_t *CommandPtr, void (*SetTimeFunc)(CFE_TIME_SysTime_t), |
Check notice
Code scanning / CodeQL
Long function without assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CFE_TIME_SetTime/MET/STCFCmd()#2339CFE_TIME_SetTimeCmd(),CFE_TIME_SetMETCmd()andCFE_TIME_SetSTCFCmd()has been factored out into a helper routine.Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Coverage/Functional Tests etc.).
Local tests confirm the modified commands are working as expected:
Net coverage is unchanged (total lines reduced by 22, total branches reduced by 4).
Expected behavior changes
Behavior/logic is unchanged.
Code duplication reduced, easing future maintenance.
System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt