feat: add flags to show individual cpu and gpu core temperatures #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivankovnatsky
force-pushed
the
main
branch
5 times, most recently
from
e731d80 to
d0ab427
Compare
Owner
|
@ivankovnatsky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 @narugit, thanks for taking the time working on this project.
I wanted to have a bit more details showing all the temperatures as the current
implementation, unless I'm mistaken, shows the average of all.
This change adds -C, -G flags to show individual CPU and GPU temperatures.
This code was mostly AI generated, I have myself very basic C++ knowledge, so
would ask for a pardon if any embarrassing issues are found.
I tested this on M3 Pro, M1 Pro and M2, comparing with Stats. M2 and M1 Pro are
fine, whereas M3 Pro is pretty off. But I see why, the code does not have all
sensors described here:
https://github.com/exelban/stats/blob/605156d323a9c119e13d7b85e594417b68ba4968/Modules/Sensors/values.swift#L409.
If you are in general open to the changes here, please let me know and I can
sync all the sensors in next PR 🙏