fix: remove ClusterName conversion in secret resolvers #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The watcher already stores secrets with environment names (e.g. prod-gcp) after converting from cluster names in newWatcher(). The resolvers were incorrectly converting environment names back to cluster names, causing 'Resource not found' errors when looking up secrets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Secrets were not found when accessing them via the console, showing errors like:
Resource not found: prod/nais/announcementsRoot cause
The watcher stores secrets with environment names (e.g.
prod-gcp) after converting from cluster names innewWatcher()(line 72 of watcher.go).The resolvers were incorrectly calling
ClusterName()to convert environment names back to cluster names before passing them to the secret package functions. This caused lookups to fail because the watcher uses environment names as keys.Fix
Remove all
ClusterName()conversions in secret.resolvers.go since the data already uses environment names throughout.