If we already know the number of affected worklods, we do not need extra #302
+59
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requests to fetch all workloads. This optimizes the response in the case of asking only for the count instead of fields for workloads related to CVEs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes GraphQL query performance by short-circuiting workload fetching when clients only request the total count of affected workloads for CVEs. Instead of fetching all workload data, the API now returns just the count if that's all that's requested.
Changes:
- Added
AffectedWorkloadsfield to theCVEstruct to cache the count from API responses - Created
onlyAsksForPageInfoTotalCounthelper to detect when only count is requested via GraphQL field introspection - Added
NewTotalCountOnlyConnectionutility to create paginated connections with only a total count
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/vulnerability/models.go | Added AffectedWorkloads field to cache workload count |
| internal/vulnerability/queries.go | Populates AffectedWorkloads when listing CVEs |
| internal/graph/pagination/models.go | Added utility function for total-count-only connections |
| internal/graph/helpers.go | Added GraphQL field introspection helpers to detect count-only queries |
| internal/graph/vulnerability.resolvers.go | Implements short-circuit optimization in Workloads resolver |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requests to fetch all workloads.
This optimizes the response in the case of asking only for the count instead of fields for workloads related to CVEs