Allow nested input filters #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d problems with composer 2.0
Migrate to Laminas/Mezzio and PHP 7.4
Signed-off-by: Pascal Heidmann <pascal.heidmann@check24.de> Co-authored-by: Pascal Heidmann <pascal.heidmann@check24.de>
As suggested in [Installation](https://github.com/Roave/SecurityAdvisories#installation) you should require "dev-latest"
use "roave/security-advisories:dev-latest" instead of "dev-master"
# Conflicts: # composer.json
[php-81] update to be compatible with php 8.1
Add test against PHP 8.2 & update dev dependencies
func0der
force-pushed
the
allow-nested-input-filters
branch
from
5017419 to
46961ce
Compare
func0der
force-pushed
the
allow-nested-input-filters
branch
from
46961ce to
1a78d94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do nested input filter definitions, you basically need to
InputFilter::add()anInputFilterInterfacewith the other inputs in them.This is mostly needed for complex json or post data structures that one would like to validate.
We are changing the output of the
errorskey inProblemDetailsResponsein that way, that we are adding new depth to the array.This COULD result in issues, as the
valueof afieldis supposed to bearray<string, string>and now becomesarray<string, array<string, string[]|string>>if that is even correct.Theoretically there is not end to the depth of nesting input filters. We are just assuming one layer here.
I need opinions here, please. Is this a breaking change?
Laying all of those options out, my answer would be yes.
Not wanting to release another major so fast after the last one, I am also open to ideas on how to release this in
3.1without breaking everything :D