Improve module build / fix TS issues #95
Open
+1,619
−7,783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi/lo props need to be definitely assigned in the constructor
Prevent returing undefined where the caller expects a Double Narrow method arg type to what the implementation can actualy handle throw if input type doesn't match
Use tsc for building compliant ESM/CJS modules with d.ts files Add dev dependency @lvlte/tsconfig (base config for dual mod) Add specific tsconfig for each module type (extends base) Replace "build-esm" script by "build-mod" (dual build) Put browser build in a dedicated folder
Also remove "esm" dev dependency (not needed anymore)
use esm module add double-double for comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #93 (at least in part: dual build ESM+CJS (ESM first) module, with d.ts emit, blocking TS issues fixed, see the commit messages for more details).
A few other things could be done here but need to be discussed :
ci,e2eandcovscripts (are they still all needed), and I'm not sure what to do with the outdated dependencies without your opinionDon't hesitate to suggest things I should add or remove from this PR.