Vehicles locations

[mmathieum]

• Real-time🛰️ vehicle locations/positions 🚌  mtransit-for-android#80

[gemini-code-assist]

Summary of Changes

Hello @mmathieum, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the GTFS data model by disentangling the 'Trip' concept from 'Direction', which were previously treated as interchangeable aliases. This change establishes 'Trip' as a distinct entity with its own dedicated database schema, improving clarity and laying groundwork for more granular data management. Additionally, new feature flags have been introduced to enable future optimizations related to service date export and schedule sorting, enhancing the system's flexibility and potential for performance improvements.

Highlights

• GTFS Trip Model Refactoring: The T_TRIP entity has been fully separated from T_DIRECTION in GTFSCommons.kt, establishing it as a distinct table with its own keys and SQL schema, moving away from previous aliasing.
• Deprecated Aliases Removal: Cleaned up GTFSCommons.kt by removing all deprecated constants and SQL objects that previously treated T_TRIP and T_TRIP_STOPS as aliases of T_DIRECTION and T_DIRECTION_STOPS respectively.
• New Feature Flags Introduced: Added two new feature flags, F_EXPORT_FLATTEN_SERVICE_DATES and F_EXPORT_SCHEDULE_SORTED_BY_ROUTE_DIRECTION, to FeatureFlags.kt, hinting at future data export and schedule optimization capabilities.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the GTFS data model by separating the Trip and Direction concepts, which were previously conflated. This is a positive change for the data model's clarity. The implementation involves removing deprecated code and introducing a new table structure. The changes are mostly solid, but I've identified a couple of areas for improvement related to code consistency and maintainability. My feedback includes a high-severity comment on inconsistent column ordering in an SQL statement and a medium-severity comment on an incomplete region tag.

[gemini-code-assist]

For consistency with other SQL_INSERT definitions in this file, and with the T_TRIP_SQL_CREATE statement, the primary key column (T_TRIP_K_ID) should be listed first. All other insert statements in this file list the primary key first, and it's good practice to keep the column order consistent between CREATE and INSERT statements for better maintainability. This inconsistency could lead to confusion and potential bugs.

Suggested change

	val T_TRIP_SQL_INSERT = SQLInsertBuilder.getNew(T_TRIP).apply {
	appendColumn(T_TRIP_K_ROUTE_ID)
	appendColumn(T_TRIP_K_DIRECTION_ID)
	appendColumn(T_TRIP_K_SERVICE_ID)
	appendColumn(T_TRIP_K_ID)
	}.build()
	val T_TRIP_SQL_INSERT = SQLInsertBuilder.getNew(T_TRIP).apply {
	appendColumn(T_TRIP_K_ID)
	appendColumn(T_TRIP_K_ROUTE_ID)
	appendColumn(T_TRIP_K_SERVICE_ID)
	appendColumn(T_TRIP_K_DIRECTION_ID)
	}.build()

[gemini-code-assist]

For consistency with other endregion comments in this file (e.g., // endregion Direction), please specify the region name here. This improves code readability and makes it easier to navigate the code using IDE features.

Suggested change

	// endregion
	// endregion Trip