feat: Add Performance Mark for Rokt Script Appended (SDKE-405) #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillermot
changed the title
rmi22186
approved these changes
Oct 21, 2025
added 2 commits
October 22, 2025 11:23
… for improved consistency
…erformance metrics
rmi22186
reviewed
Oct 22, 2025
src/Rokt-Kit.js
Outdated
|
|
||
| target.appendChild(script); | ||
| captureTimings(PerformanceMarks.RoktScriptAppended); | ||
| captureTiming(mParticle.PerformanceMarkType.RoktScriptAppended); |
Collaborator
There was a problem hiding this comment.
This is annoying, but in a world where a customer is hosting this on NPM, we'd need to check to ensure mParticle.PerformanceMarkType exists. This is an argument to just keep PerformanceMarks in this file to ensure it's always available.
cc @mattbodle
Collaborator
Author
There was a problem hiding this comment.
Yes, makes sense, forgot about npm package. let me rollback changes
rmi22186
approved these changes
Oct 23, 2025
Collaborator
|
approved, but needs to wait until https://github.com/mParticle/mparticle-web-sdk/pull/1101/files is fully rolled out to all customers |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 27, 2025
# [1.12.0](v1.11.0...v1.12.0) (2025-10-27) ### Features * Add Performance Mark for Rokt Script Appended (SDKE-405) ([#50](#50)) ([a181f54](a181f54))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds performance monitoring capabilities to the Rokt JavaScript integration kit by implementing a performance mark that tracks when the Rokt launcher script is successfully appended to the DOM. This enhancement enables better observability and performance tracking for Rokt integration initialization.
Changes Made:
Testing Plan