Skip to content

Conversation

@dschom
Copy link
Contributor

@dschom dschom commented Jan 29, 2026

Because

  • We might not want to error out if an email fails to send
  • Some emails are critical, others aren't

This pull request

  • Adds option to suppress an exception on email send
  • Updates auth-server to suppress errors for not critical emails

Issue that this pull request solves

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@dschom dschom requested a review from a team as a code owner January 29, 2026 01:21
Copy link
Contributor

@nshirley nshirley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart, I'll have some to update on my pr, but looks like it's just an optional param 👍

headers: Record<string, string>,
rendered: RenderedTemplate
rendered: RenderedTemplate,
throwErrorOnSendFailure = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed, should this default to false?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants