Return skipExtensions directly instead of exploding #16799
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes
modMediaSource::getSkipExtensionsArray()so it returns the already-parsed$skipExtensionsarray directly instead of callingexplode()a second time. Since$skipExtensionsis already converted to an array earlier in the method, re-exploding it is redundant and can cause runtime errors.Why is it needed?
Calling
explode(',', $skipExtensions)after$skipExtensionshas already been converted to an array can lead to a runtime error, especially on PHP 8+, whereexplode()requires a string. This change ensures the method consistently returns an array of extensions and avoids PHP errors.How to test
modMediaSource(or a derivative).skipExtensionsproperty to a comma-separated list (e.g.zip,rar,psd).explode()occurs.Related issue(s)/PR(s)