-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[model] support medgemma #7261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[model] support medgemma #7261
Conversation
support hunyuanOCR
fix position_ids for multi images
update faq
fix typos
update faq
…er_key_value_heads for the seq_cls task
support medgemma
Summary of ChangesHello @slin000111, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates several MedGemma models into the system, expanding the range of supported models. It includes necessary updates to the model registry, documentation, and adds dedicated test cases to verify the functionality of both text and vision capabilities of these new models. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for medgemma models. The changes include updating the supported model lists in the documentation, registering the new model IDs, and adding corresponding tests. The new tests for both the text and vision models are well-written and follow the existing testing patterns.
I have a minor suggestion for the documentation to improve clarity on the required transformers version for one of the new models. Overall, the changes are good and integrate the new models effectively.
| |[LLM-Research/gemma-3-1b-it](https://modelscope.cn/models/LLM-Research/gemma-3-1b-it)|gemma3_text|gemma3_text|transformers>=4.49|✘|-|[google/gemma-3-1b-it](https://huggingface.co/google/gemma-3-1b-it)| | ||
| |[google/gemma-3-270m](https://modelscope.cn/models/google/gemma-3-270m)|gemma3_text|gemma3_text|transformers>=4.49|✘|-|[google/gemma-3-270m](https://huggingface.co/google/gemma-3-270m)| | ||
| |[google/gemma-3-270m-it](https://modelscope.cn/models/google/gemma-3-270m-it)|gemma3_text|gemma3_text|transformers>=4.49|✘|-|[google/gemma-3-270m-it](https://huggingface.co/google/gemma-3-270m-it)| | ||
| |[google/medgemma-27b-text-it](https://modelscope.cn/models/google/medgemma-27b-text-it)|gemma3_text|gemma3_text|4.52.0.dev0|✘|-|[google/medgemma-27b-text-it](https://huggingface.co/google/medgemma-27b-text-it)| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency and clarity, it's better to specify the package name for the required version. The value 4.52.0.dev0 is ambiguous.
| |[google/medgemma-27b-text-it](https://modelscope.cn/models/google/medgemma-27b-text-it)|gemma3_text|gemma3_text|4.52.0.dev0|✘|-|[google/medgemma-27b-text-it](https://huggingface.co/google/medgemma-27b-text-it)| | |
| |[google/medgemma-27b-text-it](https://modelscope.cn/models/google/medgemma-27b-text-it)|gemma3_text|gemma3_text|transformers>=4.52.0.dev0|✘|-|[google/medgemma-27b-text-it](https://huggingface.co/google/medgemma-27b-text-it)| |
| |[LLM-Research/gemma-3-1b-it](https://modelscope.cn/models/LLM-Research/gemma-3-1b-it)|gemma3_text|gemma3_text|transformers>=4.49|✘|-|[google/gemma-3-1b-it](https://huggingface.co/google/gemma-3-1b-it)| | ||
| |[google/gemma-3-270m](https://modelscope.cn/models/google/gemma-3-270m)|gemma3_text|gemma3_text|transformers>=4.49|✘|-|[google/gemma-3-270m](https://huggingface.co/google/gemma-3-270m)| | ||
| |[google/gemma-3-270m-it](https://modelscope.cn/models/google/gemma-3-270m-it)|gemma3_text|gemma3_text|transformers>=4.49|✘|-|[google/gemma-3-270m-it](https://huggingface.co/google/gemma-3-270m-it)| | ||
| |[google/medgemma-27b-text-it](https://modelscope.cn/models/google/medgemma-27b-text-it)|gemma3_text|gemma3_text|4.52.0.dev0|✘|-|[google/medgemma-27b-text-it](https://huggingface.co/google/medgemma-27b-text-it)| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency and clarity, it's better to specify the package name for the required version. The value 4.52.0.dev0 is ambiguous.
| |[google/medgemma-27b-text-it](https://modelscope.cn/models/google/medgemma-27b-text-it)|gemma3_text|gemma3_text|4.52.0.dev0|✘|-|[google/medgemma-27b-text-it](https://huggingface.co/google/medgemma-27b-text-it)| | |
| |[google/medgemma-27b-text-it](https://modelscope.cn/models/google/medgemma-27b-text-it)|gemma3_text|gemma3_text|transformers>=4.52.0.dev0|✘|-|[google/medgemma-27b-text-it](https://huggingface.co/google/medgemma-27b-text-it)| |
PR type
PR information
Write the detail information belongs to this PR.
support medgemma, #7160
Experiment results
Paste your experiment result here(if needed).