Fix status codes for invalid session IDs in streamable HTTP examples #1424
+134
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per spec: - Missing session ID (when required) → 400 Bad Request - Invalid/unknown session ID → 404 Not Found Previous code returned 400 for both cases. This fix differentiates: - POST without session ID + not init request → 400 - POST/GET/DELETE with unknown session ID → 404 Updated examples: - jsonResponseStreamableHttp.ts - simpleStreamableHttp.ts - standaloneSseWithGetStreamableHttp.ts - elicitationFormExample.ts - elicitationUrlExample.ts - simpleTaskInteractive.ts Fixes modelcontextprotocol#389 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per the MCP spec, invalid session IDs should return 404 Not Found (to signal the client should start a new session), while missing session IDs should return 400 Bad Request.
Previous code returned 400 for both cases. This fix differentiates:
Updated examples
jsonResponseStreamableHttp.tssimpleStreamableHttp.tsstandaloneSseWithGetStreamableHttp.tselicitationFormExample.tselicitationUrlExample.tssimpleTaskInteractive.tsTest plan
pnpm typecheck:all)Fixes #389
🤖 Generated with Claude Code