Skip to content

Conversation

@martincostello
Copy link

@martincostello martincostello commented Jan 9, 2026

Add new --display-name override that allows the DisplayName to be manually specified when it includes a version string.

For example this manifest contains the version number but the update command does not currently update the value.

With these changes it's possible to override like thus:

wingetcreate update ${env:PACKAGE_ID} `
  --urls "${env:GITHUB_SERVER_URL}/${env:GITHUB_REPOSITORY}/releases/download/${env:PACKAGE_VERSION}/alloy-installer-windows-amd64.exe" `
  --version ${env:PACKAGE_VERSION}.TrimStart("v") `
  --display-version "Alloy ${env:PACKAGE_VERSION}" `
  --submit

Microsoft Reviewers: Open in CodeFlow

Add new `--display-name` override that allows the DisplayName to be manually specified when it includes a version string.
Copilot AI review requested due to automatic review settings January 9, 2026 16:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new --display-name command-line argument to the update command, allowing users to manually specify the DisplayName field when it includes version strings that need to be updated. This complements the existing --display-version functionality and addresses scenarios where package manifests contain version-specific display names.

Key Changes

  • Added new --display-name CLI option to override DisplayName values during manifest updates
  • Implemented logic to update DisplayName in AppsAndFeaturesEntries, following the same pattern as DisplayVersion
  • Added comprehensive test coverage with new test case and test manifest resource

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/WingetCreateCore/Models/InstallerMetadata.cs Adds DisplayName property to store CLI argument value
src/WingetCreateCore/Common/PackageParser.cs Implements logic to update DisplayName in installers' AppsAndFeaturesEntries
src/WingetCreateCLI/Commands/UpdateCommand.cs Defines --display-name CLI option and propagates value to installer metadata
src/WingetCreateCLI/Properties/Resources.resx Adds help text resource for the new option
src/WingetCreateCLI/Properties/Resources.Designer.cs Generated code for new resource string
doc/update.md Documents the new --display-name argument
src/WingetCreateTests/WingetCreateTests/UnitTests/UpdateCommandTests.cs Adds UpdateDisplayName test to verify the functionality
src/WingetCreateTests/WingetCreateTests/Resources/TestPublisher.UpdateDisplayName.yaml Test manifest with DisplayName field for testing
src/WingetCreateTests/WingetCreateTests/WingetCreateTests.csproj Registers new test resource file for build output
Files not reviewed (1)
  • src/WingetCreateCLI/Properties/Resources.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Address Copilot code review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant