-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Add anyspawn crate with generic Spawner trait for spawn tasks for different async runtimes #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 105 108 +3
Lines 6767 6798 +31
=======================================
+ Hits 6767 6798 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Have you thought about applying this guide to spawner? The idea is that For example: Tokio: let spawner = Spawner::new_tokio();Custom Runtime: let spawner = Spawner::new_custom(move |future| runtime_handle.spawn(future));The The downside of this approach is that we would enforce Send and Sync bounds, but this is aligned with https://microsoft.github.io/rust-guidelines/guidelines/libs/interop/index.html?highlight=Send#M-TYPES-SEND. |
I can see the value here. I guess the tradeoff would be some additional heap allocations and indirection internally, since the new_custom(...) closure will have to accept a boxed future. Once Oxidizer RT moves here we can add a direct enum variant for it to avoid that additional cost. In fact, we can probably remove this abstraction altogether at that point. |
I see the value of this type even when oxidizer rt is public. Sometimes, the library only needs to care about how to spawn tasks and using this type can simplify those scenarios. |
ralfbiedert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing
…es. Throw compile error without any features.
| #![cfg_attr(docsrs, feature(doc_cfg))] | ||
| #![warn(missing_docs)] | ||
|
|
||
| //! Async runtime abstractions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the rebrand to the new crate name, perhaps this should be less grand?
| version = "0.1.0" | ||
| readme = "README.md" | ||
| keywords = ["oxidizer", "async", "runtime", "futures"] | ||
| categories = ["Asynchronous"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure the category slugs need to be lowervase.
No description provided.