-
Notifications
You must be signed in to change notification settings - Fork 31
fix: yse SHA256 for certificate fingerprinting #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ayeshurun
wants to merge
56
commits into
microsoft:main
Choose a base branch
from
ayeshurun:use-approved-alg-in-cryptography
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: yse SHA256 for certificate fingerprinting #136
ayeshurun
wants to merge
56
commits into
microsoft:main
from
ayeshurun:use-approved-alg-in-cryptography
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: semantic pr
chore: Introduce release workflowc
… commit SHA Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
…workflow feat(ci): enhance create-release workflow with commit targeting and rich error feedback
… commit SHA Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
… commit SHA Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
Address a CodeQL alert by replacing the insecure SHA1 hash algorithm with SHA256 when generating certificate thumbprints for authentication.
type: Must be one of the following:
feat: A new featurefix: A bug fixdocs: Documentation only changesstyle: Changes that do not affect the meaning of the code (e.g., formatting)refactor: A code change that neither fixes a bug nor adds a featureperf: A code change that improves performancetest: Adding missing tests or correcting existing testschore: Changes to the build process or auxiliary toolsbuild: Changes that affect the build system or external dependenciesci: Changes to CI configuration files and scriptsrevert: Reverts a previous commit-->
✨ Description of new changes
This change affects service principal authentication using certificates. The certificate thumbprint is used by the underlying MSAL library as part of its token cache key.
This update aligns with security best practices and resolves the reported vulnerability.