fix: Add ‘properties’ field to the item metadata list to eliminate unnecessary calls to the getItemDefinition API #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
may-hartov
previously approved these changes
Jan 11, 2026
ayeshurun
reviewed
Jan 12, 2026
ayeshurun
reviewed
Jan 12, 2026
aviatco
commented
Jan 12, 2026
aviatco
commented
Jan 12, 2026
…https://github.com/aviatco/fabric-cli into dev/aviatcohen/displayDefinitionPromptOnlyWhenNeeded
ohadedry
reviewed
Jan 12, 2026
Contributor
ohadedry
left a comment
ohadedry
left a comment
There was a problem hiding this comment.
Please update description to reflect latest changes
ohadedry
reviewed
Jan 12, 2026
may-hartov
reviewed
Jan 13, 2026
may-hartov
previously approved these changes
Jan 13, 2026
aviatco
commented
Jan 14, 2026
aviatco
changed the title
ohadedry
reviewed
Jan 14, 2026
ayeshurun
reviewed
Jan 15, 2026
ayeshurun
approved these changes
Jan 15, 2026
Collaborator
ayeshurun
left a comment
ayeshurun
left a comment
There was a problem hiding this comment.
minor comment about naming in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description of new changes
Fix #127
This pull request improves how metadata property queries are handled in the CLI, specifically by adding support for nested metadata properties and reducing unnecessary API calls for item definitions. The changes enhance both performance and query flexibility, and include updates to validation logic, utility functions, and tests.
Metadata property query improvements:
is_metadata_property_queryutility function infab_cmd_get_utils.pyto correctly identify both top-level and nested metadata property queries, such asproperties.connectionStringordisplayName.localized. This centralizes and simplifies validation logic.fab_fs_get.pyandfab_fs_get_item.pyto use the new utility function for determining when to skip unnecessary calls to the getItemDefinition API, improving efficiency.Metadata property support:
propertiesto the list of recognized metadata properties infab_constant.py, enabling direct querying of thepropertiesfield.propertiesfield, eliminating unnecessary calls to the getItemDefinition API.