Skip to content

Conversation

@SumitJenaHCL
Copy link
Contributor

@SumitJenaHCL SumitJenaHCL commented Dec 23, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
This is to upgrade the package rhino to version 1.7.15.1

Change Log
  • SPECS-EXTENDED/rhino/rhino-1.7.15.1.pom
  • SPECS-EXTENDED/rhino/rhino-addOrbitManifest.patch
  • SPECS-EXTENDED/rhino/rhino-build.patch
  • SPECS-EXTENDED/rhino/rhino-build.xml
  • SPECS-EXTENDED/rhino/rhino-debugger.script
  • SPECS-EXTENDED/rhino/rhino-engine-1.7.15.1.pom
  • SPECS-EXTENDED/rhino/rhino-idswitch.script
  • SPECS-EXTENDED/rhino/rhino-jsc.script
  • SPECS-EXTENDED/rhino/rhino-runtime-1.7.15.1.pom
  • SPECS-EXTENDED/rhino/rhino.script
  • SPECS-EXTENDED/rhino/rhino.signatures.json
  • SPECS-EXTENDED/rhino/rhino.spec
  • cgmanifest.json
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

@SumitJenaHCL SumitJenaHCL requested review from a team as code owners December 23, 2025 01:53
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 23, 2025
@sandeepkarambelkar
Copy link
Contributor

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 24, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011747&view=results

Buddy Build is Successful.

Buddy Build to check the dependent package after fixing rhino - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011876&view=results

Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No any warnings in the build logs.
Buddy Build successful.
Changes LGTM

@sandeepkarambelkar
Copy link
Contributor

@SumitJenaHCL

bsf builds successfully after this change. Can you add fix for license issues of bsf in the same PR?

https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011876&view=logs&j=bac295d9-f2e0-5165-e63e-e76f383e1a27&t=9882ff2e-8593-595d-d142-3df1addc71ae

##[warning]License issues found.
WARN: (bsf-javadoc-2.4.0-19.azl3.noarch.rpm) has license warnings:
bad %doc files:
/usr/share/javadoc/bsf/legal/ADDITIONAL_LICENSE_INFO
duplicated license files:
/usr/share/javadoc/bsf/legal/LICENSE

@sandeepkarambelkar
Copy link
Contributor

Buddy Build to check dependent package license warnings fix - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1012747&view=results

@kgodara912
Copy link
Contributor

Buddy build after duplicate license file removal.

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As such changes look fine except license file. Please mark additional license info file proper as it was done in other PRs.

@sandeepkarambelkar
Copy link
Contributor

Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy build is failing because of improper change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants