Skip to content

Upgrade suitesparse to 7.11.0 #15289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
durgajagadeesh wants to merge 7 commits into
base: 3.0-dev
Choose a base branch
from
Open

Upgrade suitesparse to 7.11.0 #15289

durgajagadeesh wants to merge 7 commits into from

Conversation

@durgajagadeesh
Copy link
Contributor

@durgajagadeesh durgajagadeesh commented Dec 15, 2025 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary
  • Upgrade suitesparse to 7.11.0
  • Spec file downloaded from Fedora42.
Change Log
  • SPECS-EXTENDED/suitesparse/suitesparse.spec
  • SPECS-EXTENDED/suitesparse/suitesparse.signature.json
  • cgmanifest.json
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx
  • Build summary:
image
  • Installation:
image - Uninstallation: image

@durgajagadeesh durgajagadeesh requested review from a team as code owners December 15, 2025 09:53
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 15, 2025
@durgajagadeesh durgajagadeesh force-pushed the topic_suitesparse branch 3 times, most recently from 088ae4f to c8e85ed Compare December 15, 2025 10:27
@durgajagadeesh durgajagadeesh marked this pull request as draft December 15, 2025 10:29
@durgajagadeesh durgajagadeesh marked this pull request as ready for review December 16, 2025 04:04
sandeepkarambelkar
sandeepkarambelkar reviewed Dec 17, 2025
View reviewed changes
SPECS-EXTENDED/suitesparse/suitesparse.spec Outdated

%changelog
* Mon Dec 15 2025 Durga Jagadeesh Palli <v-dpalli@microsoft.com> - 7.11.0-1
- Upgrade to 7.11.0
Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention upgrade reference. Fedora.

Copy link
Contributor Author

@durgajagadeesh durgajagadeesh Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sandeepkarambelkar, I have incorporated the changes based on your suggestions.
-Thank you!

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 17, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1006593&view=results

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Dec 17, 2025 •
edited
Loading

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1006593&view=results

Hi @sandeepkarambelkar, can you please retrigger buddy build with the following packages?
python-sphinxcontrib-jquery tbb suitesparse
image
-Thank you!

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 17, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1006779&view=results

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 17, 2025

BB is showing license issues - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1006779&view=logs&j=eb4d3d72-7ec0-56f0-d57c-e2656014f3b8&t=cbfb6a45-b6c0-5350-5f78-359cd0425f35

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Dec 19, 2025 •
edited
Loading

BB is showing license issues - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1006779&view=logs&j=eb4d3d72-7ec0-56f0-d57c-e2656014f3b8&t=cbfb6a45-b6c0-5350-5f78-359cd0425f35

Hi @sandeepkarambelkar, I have made the necessary changes to fix the 55 license warnings in doc section.
Please retrigger the buddy build when you can, I will follow up on the results.
image

Thank you!

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 22, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1010240&view=results

@durgajagadeesh durgajagadeesh force-pushed the topic_suitesparse branch 2 times, most recently from 3d42f06 to 72a31ef Compare December 23, 2025 07:15
@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 23, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011008&view=results

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Dec 23, 2025

I have addressed contribution-license warning.
Could you please retrigger the buddy build once again.
Thank you!

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 24, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011739&view=results

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Dec 24, 2025 •
edited
Loading

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011739&view=results

Buddy build has been completed successfully.
image

Thank you!

sandeepkarambelkar
sandeepkarambelkar requested changes Dec 24, 2025
View reviewed changes
Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is rpmbuild warning -

time="2025-12-24T08:05:08Z" level=debug msg="RPM build warnings:"
time="2025-12-24T08:05:08Z" level=debug msg=" File listed twice: /usr/lib/libumfpack.so.6"
time="2025-12-24T08:05:08Z" level=debug msg=" File listed twice: /usr/lib/libumfpack.so.6.3.6"

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Dec 25, 2025 •
edited
Loading

libumfpack.so.6

Hi @sandeepkarambelkar, I have resolved this warnings and updated my changes.
image

image

-Thank you!

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 26, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1012731&view=results

sandeepkarambelkar
sandeepkarambelkar approved these changes Dec 26, 2025
View reviewed changes
Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy Build Successful.
Changes LGTM.

sandeepkarambelkar
sandeepkarambelkar requested changes Dec 31, 2025
View reviewed changes
Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License files tagging need to be verified

SPECS-EXTENDED/suitesparse/suitesparse.spec
! -iname "GPLv2.txt" \
! -iname "lesserv3.txt" \
! -iname "CONTRIBUTOR-LICENSE.txt" \
! -iname "SuiteSparse Individual Contributor License Agreement (20241011).pdf" \
Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify if all these license files are added in the licese file tagged. If not, can you actually tag all the valid license files with license tag?

Copy link
Contributor Author

@durgajagadeesh durgajagadeesh Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sandeepkarambelkar, I've verified that all license files are included in the RPM file (i.e, suitesparse-7.11.0-1.azl3.x86_64.rpm) using %license Licenses at line 331.
image

All the license files are placed in the below directory.
/usr/share/licenses/suitesparse/Licenses/
image

-Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandeepkarambelkar sandeepkarambelkar Awaiting requested review from sandeepkarambelkar

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@durgajagadeesh @sandeepkarambelkar