-
Notifications
You must be signed in to change notification settings - Fork 602
rust: Upgrade to 1.90.0 #14819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0-dev
Are you sure you want to change the base?
rust: Upgrade to 1.90.0 #14819
Conversation
|
|
36ad7a7 to
e4c6294
Compare
|
e4c6294 to
2710dda
Compare
|
|
The failing github PR checks are unrelated to this PR |
38446a5 to
874755c
Compare
| Subject: [PATCH] warnings | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use a more descriptive subject and commit message here (and same for kata-containers-cc)? Seems there are 2 aspects at play: stricter dead code linting & stricter lifetime linting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sprt Could you please review the PR once again? I have added more details in the description of this PR
| From 40df9e0f016e4ce67e90e3e7f5b0ec87c5cb0a32 Mon Sep 17 00:00:00 2001 | ||
| From: Kavya Sree Kaitepalli <kkaitepalli@microsoft.com> | ||
| Date: Tue, 28 Oct 2025 17:39:43 +0000 | ||
| Subject: [PATCH] Suppress dead_code warnings and add explicit lifetime for U32Set iterator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Subject: [PATCH] Suppress dead_code warnings and add explicit lifetime for U32Set iterator | |
| Subject: [PATCH] Suppress dead_code warnings and add explicit lifetime for U32Set iterator for Rust 1.90 |
| Source0: https://github.com/microsoft/kata-containers/archive/refs/tags/%{version}.tar.gz#/%{name}-%{version}.tar.gz | ||
| Source1: %{name}-%{version}-cargo.tar.gz | ||
|
|
||
| Patch0: 0001-warnings.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Patch0: 0001-warnings.patch | |
| Patch0: rust-1.90-fixes.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me overall.
I think once the suggestions from others are addressed, we should be good.
kgodara912
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awaiting approval.
f5230dd to
f051068
Compare
Add upstream patch reference for CVE-2025-4574.
Add detailed fix messages and upstream patch reference
f051068 to
678c1ef
Compare
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
A new patch has been introduced to resolve compilation warnings in kata-containers and kata-containers-cc that emerged with Rust 1.90.0. This patch is necessary because the kata-containers spec file requires rust >= 1.85.0, and newer Rust versions (1.88+) have stricter compiler warnings and linting rules.
Specific Fixes in the Patch:
Dead Code Warning Suppression for s390x CCW Device Handlers
Adds #[allow(dead_code)] annotations to Channel Command Word (CCW) device handler structs
Root Cause: These CCW device handlers are implemented for s390x architecture support, but since kata-containers is built exclusively for x86_64 (as specified in the spec file), these structs are defined but never actually used
Explicit Lifetime Annotation for Iterator
Updates iterator lifetime annotations from elided lifetimes to explicit '_ (anonymous lifetime)
Root Cause: Rust 1.88+ enforces more explicit lifetime annotations for iterators to improve code clarity and prevent potential lifetime-related bugs
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology
(Ptests failing in rust-cbindgen and python-argcomplete is a known issue)