-
Notifications
You must be signed in to change notification settings - Fork 1k
Python: (AG-UI) Support service-managed thread on AG-UI #3136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
howlowck
wants to merge
11
commits into
microsoft:main
Choose a base branch
from
howlowck:feature/ag-ui-proper-conversation-id-run-id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+307
−27
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0a432e5
added service thread support
howlowck abc5a11
set service_thread_id to only supplied_thread_id
howlowck e99bf5f
uses raw_representation to extract the conversation_id
howlowck fb8543c
removed accidental edit
howlowck 48066fd
updated test to use raw_representation
howlowck 1fecf5e
resolves copilot review feedback
howlowck 11761fe
revert back StubAgent, since not used
howlowck c9ed539
removed relative module import
howlowck 5f9eec8
merged main
howlowck fcec337
merged main
howlowck 711200e
removed hasattr check per PR feedback
howlowck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the naming
_supplied_run_idis slightly misleading after mutation - consider_resolved_run_idif you agree it's clearer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm.. by
suppliedI meant to convey that the id was "supplied" by an external source (by user or by the service), not randomly generated.. so even if it is mutated (with theupdate_*method), it's still supplied by an external source. Unless I misunderstood your feedback. Or Maybeprovidedis better?I'm also not stuck on the naming of this property, so if you feel strongly about the proposed name, I'm happy to change it to
_resolved_*_id