Skip to content

Fix casing of IsRefreshable in Dataset.Serialization.cs #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arjan321 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix casing of IsRefreshable in Dataset.Serialization.cs #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions sdk/PowerBI.Api/Source/Models/AdminDataset.Serialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,22 +35,22 @@ void IUtf8JsonSerializable.Write(Utf8JsonWriter writer)
}
if (Optional.IsDefined(IsEffectiveIdentityRequired))
{
writer.WritePropertyName("IsEffectiveIdentityRequired"u8);
writer.WritePropertyName("isEffectiveIdentityRequired"u8);
writer.WriteBooleanValue(IsEffectiveIdentityRequired.Value);
}
if (Optional.IsDefined(IsEffectiveIdentityRolesRequired))
{
writer.WritePropertyName("IsEffectiveIdentityRolesRequired"u8);
writer.WritePropertyName("isEffectiveIdentityRolesRequired"u8);
writer.WriteBooleanValue(IsEffectiveIdentityRolesRequired.Value);
}
if (Optional.IsDefined(IsOnPremGatewayRequired))
{
writer.WritePropertyName("IsOnPremGatewayRequired"u8);
writer.WritePropertyName("isOnPremGatewayRequired"u8);
writer.WriteBooleanValue(IsOnPremGatewayRequired.Value);
}
if (Optional.IsDefined(Encryption))
{
writer.WritePropertyName("Encryption"u8);
writer.WritePropertyName("encryption"u8);
writer.WriteObjectValue(Encryption);
}
if (Optional.IsCollectionDefined(Users))
Expand All @@ -70,12 +70,12 @@ void IUtf8JsonSerializable.Write(Utf8JsonWriter writer)
}
if (Optional.IsDefined(IsRefreshable))
{
writer.WritePropertyName("IsRefreshable"u8);
writer.WritePropertyName("isRefreshable"u8);
writer.WriteBooleanValue(IsRefreshable.Value);
}
if (Optional.IsDefined(IsInPlaceSharingEnabled))
{
writer.WritePropertyName("IsInPlaceSharingEnabled"u8);
writer.WritePropertyName("isInPlaceSharingEnabled"u8);
writer.WriteBooleanValue(IsInPlaceSharingEnabled.Value);
}
if (Optional.IsDefined(TargetStorageMode))
Expand Down Expand Up @@ -181,7 +181,7 @@ internal static AdminDataset DeserializeAdminDataset(JsonElement element)
webUrl = property.Value.GetString();
continue;
}
if (property.NameEquals("IsEffectiveIdentityRequired"u8))
if (property.NameEquals("isEffectiveIdentityRequired"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand All @@ -190,7 +190,7 @@ internal static AdminDataset DeserializeAdminDataset(JsonElement element)
isEffectiveIdentityRequired = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("IsEffectiveIdentityRolesRequired"u8))
if (property.NameEquals("isEffectiveIdentityRolesRequired"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand All @@ -199,7 +199,7 @@ internal static AdminDataset DeserializeAdminDataset(JsonElement element)
isEffectiveIdentityRolesRequired = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("IsOnPremGatewayRequired"u8))
if (property.NameEquals("isOnPremGatewayRequired"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand All @@ -208,7 +208,7 @@ internal static AdminDataset DeserializeAdminDataset(JsonElement element)
isOnPremGatewayRequired = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("Encryption"u8))
if (property.NameEquals("encryption"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand Down Expand Up @@ -240,7 +240,7 @@ internal static AdminDataset DeserializeAdminDataset(JsonElement element)
addRowsAPIEnabled = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("IsRefreshable"u8))
if (property.NameEquals("isRefreshable"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand All @@ -249,7 +249,7 @@ internal static AdminDataset DeserializeAdminDataset(JsonElement element)
isRefreshable = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("IsInPlaceSharingEnabled"u8))
if (property.NameEquals("isInPlaceSharingEnabled"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand Down
24 changes: 12 additions & 12 deletions sdk/PowerBI.Api/Source/Models/Dataset.Serialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,22 +35,22 @@ void IUtf8JsonSerializable.Write(Utf8JsonWriter writer)
}
if (Optional.IsDefined(IsEffectiveIdentityRequired))
{
writer.WritePropertyName("IsEffectiveIdentityRequired"u8);
writer.WritePropertyName("isEffectiveIdentityRequired"u8);
writer.WriteBooleanValue(IsEffectiveIdentityRequired.Value);
}
if (Optional.IsDefined(IsEffectiveIdentityRolesRequired))
{
writer.WritePropertyName("IsEffectiveIdentityRolesRequired"u8);
writer.WritePropertyName("isEffectiveIdentityRolesRequired"u8);
writer.WriteBooleanValue(IsEffectiveIdentityRolesRequired.Value);
}
if (Optional.IsDefined(IsOnPremGatewayRequired))
{
writer.WritePropertyName("IsOnPremGatewayRequired"u8);
writer.WritePropertyName("isOnPremGatewayRequired"u8);
writer.WriteBooleanValue(IsOnPremGatewayRequired.Value);
}
if (Optional.IsDefined(Encryption))
{
writer.WritePropertyName("Encryption"u8);
writer.WritePropertyName("encryption"u8);
writer.WriteObjectValue(Encryption);
}
if (Optional.IsCollectionDefined(Users))
Expand All @@ -70,12 +70,12 @@ void IUtf8JsonSerializable.Write(Utf8JsonWriter writer)
}
if (Optional.IsDefined(IsRefreshable))
{
writer.WritePropertyName("IsRefreshable"u8);
writer.WritePropertyName("isRefreshable"u8);
writer.WriteBooleanValue(IsRefreshable.Value);
}
if (Optional.IsDefined(IsInPlaceSharingEnabled))
{
writer.WritePropertyName("IsInPlaceSharingEnabled"u8);
writer.WritePropertyName("isInPlaceSharingEnabled"u8);
writer.WriteBooleanValue(IsInPlaceSharingEnabled.Value);
}
if (Optional.IsDefined(TargetStorageMode))
Expand Down Expand Up @@ -175,7 +175,7 @@ internal static Dataset DeserializeDataset(JsonElement element)
webUrl = property.Value.GetString();
continue;
}
if (property.NameEquals("IsEffectiveIdentityRequired"u8))
if (property.NameEquals("isEffectiveIdentityRequired"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand All @@ -184,7 +184,7 @@ internal static Dataset DeserializeDataset(JsonElement element)
isEffectiveIdentityRequired = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("IsEffectiveIdentityRolesRequired"u8))
if (property.NameEquals("isEffectiveIdentityRolesRequired"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand All @@ -193,7 +193,7 @@ internal static Dataset DeserializeDataset(JsonElement element)
isEffectiveIdentityRolesRequired = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("IsOnPremGatewayRequired"u8))
if (property.NameEquals("isOnPremGatewayRequired"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand All @@ -202,7 +202,7 @@ internal static Dataset DeserializeDataset(JsonElement element)
isOnPremGatewayRequired = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("Encryption"u8))
if (property.NameEquals("encryption"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand Down Expand Up @@ -234,7 +234,7 @@ internal static Dataset DeserializeDataset(JsonElement element)
addRowsAPIEnabled = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("IsRefreshable"u8))
if (property.NameEquals("isRefreshable"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand All @@ -243,7 +243,7 @@ internal static Dataset DeserializeDataset(JsonElement element)
isRefreshable = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("IsInPlaceSharingEnabled"u8))
if (property.NameEquals("isInPlaceSharingEnabled"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand Down
8 changes: 4 additions & 4 deletions sdk/PowerBI.Api/Source/Models/DatasetMiscProperties.Serialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ void IUtf8JsonSerializable.Write(Utf8JsonWriter writer)
}
if (Optional.IsDefined(IsRefreshable))
{
writer.WritePropertyName("IsRefreshable"u8);
writer.WritePropertyName("isRefreshable"u8);
writer.WriteBooleanValue(IsRefreshable.Value);
}
if (Optional.IsDefined(IsInPlaceSharingEnabled))
{
writer.WritePropertyName("IsInPlaceSharingEnabled"u8);
writer.WritePropertyName("isInPlaceSharingEnabled"u8);
writer.WriteBooleanValue(IsInPlaceSharingEnabled.Value);
}
writer.WriteEndObject();
Expand All @@ -54,7 +54,7 @@ internal static DatasetMiscProperties DeserializeDatasetMiscProperties(JsonEleme
addRowsAPIEnabled = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("IsRefreshable"u8))
if (property.NameEquals("isRefreshable"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand All @@ -63,7 +63,7 @@ internal static DatasetMiscProperties DeserializeDatasetMiscProperties(JsonEleme
isRefreshable = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("IsInPlaceSharingEnabled"u8))
if (property.NameEquals("isInPlaceSharingEnabled"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand Down
16 changes: 8 additions & 8 deletions sdk/PowerBI.Api/Source/Models/DatasetSecurityProperties.Serialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,22 @@ void IUtf8JsonSerializable.Write(Utf8JsonWriter writer)
writer.WriteStartObject();
if (Optional.IsDefined(IsEffectiveIdentityRequired))
{
writer.WritePropertyName("IsEffectiveIdentityRequired"u8);
writer.WritePropertyName("isEffectiveIdentityRequired"u8);
writer.WriteBooleanValue(IsEffectiveIdentityRequired.Value);
}
if (Optional.IsDefined(IsEffectiveIdentityRolesRequired))
{
writer.WritePropertyName("IsEffectiveIdentityRolesRequired"u8);
writer.WritePropertyName("isEffectiveIdentityRolesRequired"u8);
writer.WriteBooleanValue(IsEffectiveIdentityRolesRequired.Value);
}
if (Optional.IsDefined(IsOnPremGatewayRequired))
{
writer.WritePropertyName("IsOnPremGatewayRequired"u8);
writer.WritePropertyName("isOnPremGatewayRequired"u8);
writer.WriteBooleanValue(IsOnPremGatewayRequired.Value);
}
if (Optional.IsDefined(Encryption))
{
writer.WritePropertyName("Encryption"u8);
writer.WritePropertyName("encryption"u8);
writer.WriteObjectValue(Encryption);
}
writer.WriteEndObject();
Expand All @@ -51,7 +51,7 @@ internal static DatasetSecurityProperties DeserializeDatasetSecurityProperties(J
Encryption encryption = default;
foreach (var property in element.EnumerateObject())
{
if (property.NameEquals("IsEffectiveIdentityRequired"u8))
if (property.NameEquals("isEffectiveIdentityRequired"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand All @@ -60,7 +60,7 @@ internal static DatasetSecurityProperties DeserializeDatasetSecurityProperties(J
isEffectiveIdentityRequired = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("IsEffectiveIdentityRolesRequired"u8))
if (property.NameEquals("isEffectiveIdentityRolesRequired"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand All @@ -69,7 +69,7 @@ internal static DatasetSecurityProperties DeserializeDatasetSecurityProperties(J
isEffectiveIdentityRolesRequired = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("IsOnPremGatewayRequired"u8))
if (property.NameEquals("isOnPremGatewayRequired"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand All @@ -78,7 +78,7 @@ internal static DatasetSecurityProperties DeserializeDatasetSecurityProperties(J
isOnPremGatewayRequired = property.Value.GetBoolean();
continue;
}
if (property.NameEquals("Encryption"u8))
if (property.NameEquals("encryption"u8))
{
if (property.Value.ValueKind == JsonValueKind.Null)
{
Expand Down
12 changes: 6 additions & 6 deletions sdk/swaggers/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23203,11 +23203,11 @@
"type": "boolean",
"description": "Whether the dataset allows adding new rows"
},
"IsRefreshable": {
"isRefreshable": {
"type": "boolean",
"description": "This field returns `true` when the dataset is either recently refreshed or is configured for automatic refresh, with the connection mode specifically set to 'Import'. The value will return `false` for other connection modes, such as 'DirectQuery' and 'LiveConnection', regardless of whether the dataset is manually refreshed or is set up for automatic refresh."
},
"IsInPlaceSharingEnabled": {
"isInPlaceSharingEnabled": {
"type": "boolean",
"description": "Whether the dataset can be shared with external users to be consumed in their own tenant"
}
Expand All @@ -23216,19 +23216,19 @@
"DatasetSecurityProperties": {
"description": "A list of security related properties of a Power BI dataset.",
"properties": {
"IsEffectiveIdentityRequired": {
"isEffectiveIdentityRequired": {
"type": "boolean",
"description": "Whether the dataset requires an effective identity, which you must send in a [GenerateToken](/rest/api/power-bi/embed-token/generate-token) API call."
},
"IsEffectiveIdentityRolesRequired": {
"isEffectiveIdentityRolesRequired": {
"type": "boolean",
"description": "Whether row-level security is defined inside the Power BI .pbix file. If so, you must specify a role."
},
"IsOnPremGatewayRequired": {
"isOnPremGatewayRequired": {
"type": "boolean",
"description": "Whether the dataset requires an on-premises data gateway"
},
"Encryption": {
"encryption": {
"$ref": "#/definitions/Encryption",
"description": "Dataset encryption information. Only applicable when `$expand` is specified."
}
Expand Down