Skip to content

Propagate environment comparison threshold #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rosscutler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Propagate environment comparison threshold #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/assets_master_script/acr_result_parser_template.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ rejection_feedback :Answer to this assignment did not pass the quality control c
[accept_and_use]
# including acceptance_criteria
variance_bigger_equal: 0.1
gold_standard_bigger_equal: 1
correct_cmp_bigger_equal: 2
gold_standard_bigger_equal: 1
correct_cmp_bigger_equal: {{cfg.cmp_pass_threshold}}
#outlier_removal: true

[bonus]
Expand Down
4 changes: 2 additions & 2 deletions src/assets_master_script/dcr_ccr_result_parser_template.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ rejection_feedback :Answer to this assignment did not pass the quality control c

[accept_and_use]
# including acceptance_criteria
variance_bigger_equal: 0.1
correct_cmp_bigger_equal: 2
variance_bigger_equal: 0.1
correct_cmp_bigger_equal: {{cfg.cmp_pass_threshold}}
#outlier_removal: true

[bonus]
Expand Down
2 changes: 1 addition & 1 deletion src/assets_master_script/p804_result_parser_template.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ block_rater_if_acceptance_and_used_rate_below : 20
# including acceptance_criteria
variance_bigger_equal: 0.1
gold_standard_bigger_equal: 2
correct_cmp_bigger_equal: 2
correct_cmp_bigger_equal: {{cfg.cmp_pass_threshold}}
outlier_removal: true
rater_min_acceptance_rate_current_test : 50
rater_min_accepted_hits_current_test : 1
Expand Down
2 changes: 1 addition & 1 deletion src/assets_master_script/pp835_result_parser_template.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ block_rater_if_acceptance_and_used_rate_below : 20
# including acceptance_criteria
variance_bigger_equal: 0.1
gold_standard_bigger_equal: 1
correct_cmp_bigger_equal: 2
correct_cmp_bigger_equal: {{cfg.cmp_pass_threshold}}
#outlier_removal: true
rater_min_acceptance_rate_current_test : 50
rater_min_accepted_hits_current_test : 1
Expand Down
6 changes: 4 additions & 2 deletions src/master_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,9 @@ def create_analyzer_cfg_general(cfg, cfg_section, template_path, out_path, gener
config['condition_keys'] = cfg['create_input'].get("condition_keys", default_keys)

# BW check
config['bw_min'] = general_cfg['bw_min']
config['bw_max'] = general_cfg['bw_max']
config['bw_min'] = general_cfg['bw_min']
config['bw_max'] = general_cfg['bw_max']
config['cmp_pass_threshold'] = general_cfg['cmp_pass_threshold']

with open(template_path, 'r') as file:
content = file.read()
Expand Down Expand Up @@ -134,6 +135,7 @@ def create_analyzer_cfg_dcr_ccr(cfg, template_path, out_path, general_cfg, n_HIT
# BW check
config['bw_min'] = general_cfg['bw_min']
config['bw_max'] = general_cfg['bw_max']
config['cmp_pass_threshold'] = general_cfg['cmp_pass_threshold']

with open(template_path, 'r') as file:
content = file.read()
Expand Down