Fix UMP to BS Transform translation to account for multiple groups #830
+303
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #829 and #822
Works around RPN/NRPN bug/limitation in AM_MIDI2 lib where it uses RPN/NRPN running status even if the group index is different. (Also opened an issue on Andrew's repo for that)
Fix UMP to BS Transform processing of messages to handle changes in group across the buffer (this is an important bug because it causes loss of group information whenever we translate from UMP to Bytestream. This would not impact the KS Aggregate MIDI transport because this check is performed elsewhere, but it would impact MIDI 1.0 clients connected to any device (MIDI 1 or MIDI 2) which has more than one Group Index).
Add additional test for the UMP Iterator and add tests to validate multi-group handling for UMPToBSTransform.