Mapping RuntimeClassNames of Instantiated Generic Types #2177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to user/kythant/GenericInstantiationRuntimeclassNames
…to user/kythant/GenericInstantiationRuntimeclassNames
kythant
changed the title
Sergio0694
requested changes
Jan 15, 2026
Sergio0694
reviewed
Jan 16, 2026
src/WinRT.Interop.Generator/Helpers/RuntimeClassNameGenerator.cs
Outdated
Show resolved
Hide resolved
src/WinRT.Interop.Generator/Helpers/RuntimeClassNameGenerator.cs
Outdated
Show resolved
Hide resolved
…to user/kythant/GenericInstantiationRuntimeclassNames
…ttps://github.com/microsoft/CsWinRT into user/kythant/GenericInstantiationRuntimeclassNames
Replaces calls to GetGenericInstanceRuntimeClassName with GetRuntimeClassName throughout InteropTypeDefinitionBuilder. Refactors and renames the helper in RuntimeClassNameGenerator for improved clarity and consistency in generating Windows Runtime class names for types, including generic and array types.
Sergio0694
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map System.* to Windows.Foundation.* in Instantiated Generic Types
For primitives types such System.Int32 also need to map to just Int32