Replace direct codeunit calls with interface abstraction in PEPPOL XMLports #6310
+75
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XMLports were directly instantiating
PEPPOL30 Commoncodeunit, bypassing the interface layer used throughout the rest of the PEPPOL codebase.Changes
PEPPOL Document Processorwith methods for document processing operations (GetTotals,GetInvoiceRoundingLine,SetFilters)PEPPOL30 Common: Implements new interfacePEPPOL 3.0 Formatenum: Added interface binding with default implementationSalesInvoicePEPPOL30andSalesCrMemoPEPPOL30Example
Before:
After:
The format enum is cached to avoid redundant
GetFormat()calls.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.