-
Notifications
You must be signed in to change notification settings - Fork 181
deliverToAppSource.ProductId needs to be specified (Library app) #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@microsoft-github-policy-service agree |
|
@freddydk please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
@fvet feel free to update AL-Go system files with freddydk/AL-Go@issue2095 and see whether this fixes the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request fixes issue #2095 where the "Publish to AppSource" action fails when library projects exist in a multi-project repository without a deliverToAppSource.ProductId defined. The fix allows the action to skip library projects instead of throwing an error, enabling users to use wildcards ('*') to deliver all AppSource-enabled projects without manually excluding library projects.
Changes:
- Modified the delivery logic to skip projects without a ProductId instead of failing
- Added a check to detect library projects early in the AppSource delivery flow
- Updated release notes to document the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Actions/Deliver/Deliver.ps1 | Added early check to skip projects without ProductId; removed the later error throw that was preventing library projects from being gracefully skipped |
| RELEASENOTES.md | Added entry documenting the fix for issue #2095 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
❔What, Why & How
Deliver to AppSource will try to submit all projects to AppSource even though no ProductId is defined and hence fail when library projects exists
Related to issue: #2095
Fixes #2095
✅ Checklist