Skip to content

Conversation

@Katotodan
Copy link

Notes for Reviewers
Update figma invite link
This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Katotodan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Figma invite link in several issue templates within the repository. The change ensures that contributors and users are directed to the correct Figma resource when referencing UI designs and wireframes.

Highlights

  • Figma URL Update: The primary change in this PR is the update of the Figma URL across multiple issue templates.
  • Issue Template Modifications: The Figma URL has been updated in the following files: .github/ISSUE_TEMPLATE/documentation.md, .github/ISSUE_TEMPLATE/fbug_report.md, .github/ISSUE_TEMPLATE/meshery-extensions_bug.md, .github/ISSUE_TEMPLATE/meshery-extensions_feature.md, .github/ISSUE_TEMPLATE/meshery-ui_bug.md, and .github/ISSUE_TEMPLATE/meshery-ui_feature.md.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the Figma invite link across six different issue templates. The change is straightforward and achieves its goal. My review includes a suggestion to improve the maintainability of these templates by centralizing the recurring contributor links. This would prevent the need for updating multiple files when links change in the future, reducing maintenance effort and potential for inconsistencies.

- Meshery documentation [site](https://docs.meshery.io/) and [source](https://github.com/meshery/meshery/tree/master/docs)
- 🛠 [Meshery Build & Release Strategy](https://docs.meshery.io/project/contributing/build-and-release)
- 🎨 Wireframes and [designs for Meshery UI](https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI) in Figma [(open invite)](https://www.figma.com/team_invite/redeem/qJy1c95qirjgWQODApilR9)
- 🎨 Wireframes and [designs for Meshery UI](https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI) in Figma [(open invite)](https://www.figma.com/team_invite/redeem/GvB8SudhEOoq3JOvoLaoMs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This Figma invite link is now present in at least six issue templates. To improve maintainability and avoid having to update multiple files every time a link changes, consider creating a central 'Contributor Resources' page on your documentation site (docs.meshery.io). This page could contain all the common links (Figma, Slack, Discussion Forum, etc.). You could then replace the duplicated list of links in each template with a single link to this centralized page. This would make future updates much simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants