-
Notifications
You must be signed in to change notification settings - Fork 10
chore: update Figma URL #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
Summary of ChangesHello @Katotodan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Figma invite link in several issue templates within the repository. The change ensures that contributors and users are directed to the correct Figma resource when referencing UI designs and wireframes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the Figma invite link across six different issue templates. The change is straightforward and achieves its goal. My review includes a suggestion to improve the maintainability of these templates by centralizing the recurring contributor links. This would prevent the need for updating multiple files when links change in the future, reducing maintenance effort and potential for inconsistencies.
| - Meshery documentation [site](https://docs.meshery.io/) and [source](https://github.com/meshery/meshery/tree/master/docs) | ||
| - 🛠 [Meshery Build & Release Strategy](https://docs.meshery.io/project/contributing/build-and-release) | ||
| - 🎨 Wireframes and [designs for Meshery UI](https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI) in Figma [(open invite)](https://www.figma.com/team_invite/redeem/qJy1c95qirjgWQODApilR9) | ||
| - 🎨 Wireframes and [designs for Meshery UI](https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI) in Figma [(open invite)](https://www.figma.com/team_invite/redeem/GvB8SudhEOoq3JOvoLaoMs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Figma invite link is now present in at least six issue templates. To improve maintainability and avoid having to update multiple files every time a link changes, consider creating a central 'Contributor Resources' page on your documentation site (docs.meshery.io). This page could contain all the common links (Figma, Slack, Discussion Forum, etc.). You could then replace the duplicated list of links in each template with a single link to this centralized page. This would make future updates much simpler.
Notes for Reviewers
Update figma invite link
This PR fixes #
Signed commits