Skip to content

Conversation

@basdebakker
Copy link
Member

No description provided.

@basdebakker
Copy link
Member Author

For 11.6. Needs team review.

Example:

```sql
INSERT INTO Module.Order ( OrderId, CustomerId )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that using Id as column name here can be misleading to the customers. Perhaps it would be slightly clearer with different column names

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the Ids to Numbers.

WHERE Module.Customer/Name = 'Mary' )
```

## `INSERT` Statement {#oql-insert}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this above UPDATE. Although we implemented it last, intuitively it is the first statement type to learn and use. Also, that would resolve the fact that ## Joins section is in the middle of statement types

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand, it is the one I have heard the least use cases for, so I wouldn't think it's the first to use. As to the Joins section, it only applies to deletes and updates, which is emphasized by the current order.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, so let's keep it like this then.

@basdebakker basdebakker force-pushed the oql-insert-attributes branch from 06c28ac to b6b0d02 Compare December 18, 2025 09:35
@dahfjkg
Copy link
Contributor

dahfjkg commented Dec 18, 2025

Passed technical review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants