-
Notifications
You must be signed in to change notification settings - Fork 767
Add documentation on OQL INSERT statement #10496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
|
For 11.6. Needs team review. |
| Example: | ||
|
|
||
| ```sql | ||
| INSERT INTO Module.Order ( OrderId, CustomerId ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that using Id as column name here can be misleading to the customers. Perhaps it would be slightly clearer with different column names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed the Ids to Numbers.
| WHERE Module.Customer/Name = 'Mary' ) | ||
| ``` | ||
|
|
||
| ## `INSERT` Statement {#oql-insert} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this above UPDATE. Although we implemented it last, intuitively it is the first statement type to learn and use. Also, that would resolve the fact that ## Joins section is in the middle of statement types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, it is the one I have heard the least use cases for, so I wouldn't think it's the first to use. As to the Joins section, it only applies to deletes and updates, which is emphasized by the current order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, so let's keep it like this then.
06c28ac to
b6b0d02
Compare
|
Passed technical review |
No description provided.