[DRAFT] Improve init, encode, cli #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdomke
reviewed
May 20, 2025
| core_schema.no_info_plain_validator_function(ULID), | ||
| core_schema.str_schema(pattern=r"[A-Z0-9]{26}", min_length=26, max_length=26), | ||
| core_schema.str_schema( | ||
| pattern=rf"[{base32.ENCODE}]{{26}}", min_length=26, max_length=26 |
Owner
There was a problem hiding this comment.
There is a test that would need to be adapted. Good catch with the I, though.
Contributor
Author
There was a problem hiding this comment.
Ok, I missed this issue and I'll follow up on a fix
|
|
||
| @staticmethod | ||
| def _gen_bytes_from_ts(ts_ms: int | None = None) -> bytes: | ||
| """Generate a new ULID bytes from the timestamp(ms).""" |
Owner
There was a problem hiding this comment.
- All the other methods use the more lengthy word "timestamp" so that I would like to keep it consistent: What do you think about
_bytes_from_timestamp(...) - The docstring could be "Generate a ULID byte sequence of from a timestamp"
Owner
|
Please execute the tests with |
Contributor
Author
|
Ok, sorry for the misunderstanding, it's still just part of this PR (it's not a full version) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #38