Fix sphinx warnings #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also fixes this warning:
Explicit markup ends without a blank line; unexpected unindent.
…`datetime.datetime` from the Python stdlib
merwok
reviewed
Mar 19, 2025
| import time | ||
| import uuid | ||
| from datetime import datetime | ||
| from datetime import timezone |
There was a problem hiding this comment.
It is much nicer to write and read code that does from datetime import datetime, timezone
Owner
There was a problem hiding this comment.
Is this really necessary in order to get rid of the Sphinx warnings?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 287 286 -1
Branches 46 46
=========================================
- Hits 287 286 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes most of warnings reported in #32 + other fixes explained briefly in each commit message.
Remaining warnings will be fixable using
typing.Self(but only when dropping Python < 3.11, so it's not for tomorrow):