fix(ui): add content left padding #671
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
reviewed
Sep 1, 2025
Contributor
caugner
left a comment
caugner
left a comment
There was a problem hiding this comment.
I don't think the # indicator justifies taking away 1rem from the content area, so we should probably find a different solution.
I can think of two approaches:
- Reduce the size of the indicator, avoiding the overflow.
- Move the indicator behind the heading again (i.e. reverting mdn/yari#8532). To avoid mdn/yari#6647, we might be able to reserve space for the indicator behind the heading, even when hidden.
Contributor
|
/cc @mdn/content-team |
Contributor
Author
|
How about we reduce the right shift from hash.mp4For this check the latest commit in your local.
It looks weird when def list items in value sections show hash mark on left and headings show it on right :| |
caugner
added
the
needs content decision
Contributor
|
bf48e08 was deployed to: https://fred-pr671.review.mdn.allizom.net/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Need to provide more space for
#indicators on the left side. Current padding for the content sections is zero.Motivation
Additional details
After fix gap:
