Skip to content

refactor: more session extensions #7602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mscolnick wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor: more session extensions #7602

mscolnick wants to merge 4 commits into from
+451 −98

Conversation

@mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Dec 23, 2025 •
edited
Loading

This refactors more code into extensions:

  • SessionViewExtension for listening to events to put into the session view
  • QueueExtension to place commands and stdin on queues (and logic for which queue)
  • ReplayExtension extension to replay certain commands to other consumers

@vercel
Copy link

vercel bot commented Dec 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
marimo-docs Ready Ready Preview, Comment Dec 24, 2025 4:07pm

@mscolnick mscolnick requested review from Copilot and manzt December 23, 2025 21:48
Copilot AI reviewed Dec 23, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions github-actions bot added the bash-focus Area to focus on during release bug bash label Dec 24, 2025
@mscolnick mscolnick requested a review from Copilot December 24, 2025 16:17
Copilot AI reviewed Dec 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@dmadisetti dmadisetti Awaiting requested review from dmadisetti dmadisetti is a code owner

@manzt manzt Awaiting requested review from manzt

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bash-focus Area to focus on during release bug bash

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mscolnick