Fix WebSocket daemon initial queue sync on session join #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was a race condition where the session-joined message could be processed before the QueueContext had registered its subscription handler. Changes: - Store initial queue data in a ref when session-joined is received - Replay pending initial data to new subscribers when they register - Always send initial-queue-data notification (even when empty) to ensure the QueueContext can set initialQueueDataReceivedFromPeers flag - Clear pending data on disconnect, session end, and connection close
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Added console.log statements to trace the queue sync flow: - Server: log when queue state is fetched/persisted, and session-joined sent - Client: log when session-joined is received and initial-queue-data is processed - Client: log when subscribers register and if pending data is sent This will help identify where the initial queue sync is failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was a race condition where the session-joined message could be
processed before the QueueContext had registered its subscription handler.
Changes:
the QueueContext can set initialQueueDataReceivedFromPeers flag